Code review comment for lp:~cyphermox/xscreensaver/update-to-5.14

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Hi Tormod,

The changelog will contain all the history that was currently available to me, so all that was there past Jeremy's merge.

Standards-Version is at 3.9.2 now because I got this in this merge, it was set to 3.9.1 in Ubuntu's 5.13-1ubuntu1, but that's just AFAICT merging the right stuff from Debian.

The memory leak patch was dropped, it was clearly included upstream (and this would have failed even quick testing, resulting in a double-free). I also dropped xli | xloadimage from Suggests seeing as it was dropped from Recommends in Debian; rationale is that gdkpixbuf is used instead.

I'll double-check for debian/xscreensaver.desktop.. The slideshow patch is indeed missing, thanks for the catch!

« Back to merge proposal