Merge lp:~danci-emanuel/mailman/messages_support into lp:~danci-emanuel/mailman/dlist_runner
Proposed by
Emanuel Danci
Status: | Needs review |
---|---|
Proposed branch: | lp:~danci-emanuel/mailman/messages_support |
Merge into: | lp:~danci-emanuel/mailman/dlist_runner |
Diff against target: |
147 lines (+25/-6) 8 files modified
src/mailman/app/moderator.py (+1/-1) src/mailman/database/schema/postgres.sql (+1/-0) src/mailman/database/schema/sqlite.sql (+1/-0) src/mailman/interfaces/mailinglist.py (+1/-1) src/mailman/interfaces/messages.py (+5/-1) src/mailman/model/message.py (+4/-1) src/mailman/model/messagestore.py (+11/-2) src/mailman/rules/max_size.py (+1/-0) |
To merge this branch: | bzr merge lp:~danci-emanuel/mailman/messages_support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Terri | Pending | ||
Robin J | Pending | ||
Review via email: mp+124798@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 7165. By Emanuel Danci
-
Added the missing part from the messages.
Just some small comments:
1. This is only the part that will be used by the handlers when creating the new messags. (the equivalent of the Message class from DlistUtils)
2. I did not push the code for the other parts of the DlistUtils (the ones related to the Thread and Override classes) because I still have to finish some parts of them and I also took you advice, pushing smaller pieces of code, so that they will be easier to review.
3. I also changed the attribute from mailinglist.py, the one that you told me to, and added the missing line to max_size.py.
4. I tried to add Terri as I reviewer to, but I cannot seem to find her on launchpad.