Code review comment for lp:~danilo/launchpad/bug-429414

Revision history for this message
Данило Шеган (danilo) wrote :

= Bug 429414 =

This branch converts productseries-translations.pt and
sourcepackage-translate.pt/object-translations.pt to 3.0 layout.

Along the way, sourcepackage-translate.pt is removed and
object-translations.pt is renamed to sourcepackage-translations.pt (to
match other templates like distroseries-translations,
distribution-translations, product-translations,...).

It seems like a big branch, but with most links inline, pagetest updates
take 340 lines.

= Tests =

bin/test -vvt translations.*sourcepackage -t translations.*productseries

= Demo & QA =

ProductSeries page:

https://translations.launchpad.dev/evolution/trunk
https://translations.launchpad.dev/firefox/trunk

SourcePackage page:

https://translations.launchpad.dev/ubuntu/hoary/+source/evolution/

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/translations/browser/configure.zcml
  lib/lp/translations/browser/productseries.py

lib/lp/translations/stories/distribution/xx-distribution-translations.txt

lib/lp/translations/stories/importqueue/xx-translation-import-queue-targets.txt

lib/lp/translations/stories/productseries/xx-productseries-templates.txt

lib/lp/translations/stories/productseries/xx-productseries-translation-export.txt

lib/lp/translations/stories/productseries/xx-productseries-translations-bzr-request.txt

lib/lp/translations/stories/productseries/xx-productseries-translations-settings.txt
  lib/lp/translations/stories/standalone/xx-product-export.txt

lib/lp/translations/stories/standalone/xx-productseries-translations.txt

lib/lp/translations/stories/standalone/xx-rosetta-sourcepackage-list.txt
  lib/lp/translations/stories/standalone/xx-sourcepackage-export.txt

lib/lp/translations/stories/standalone/xx-template-description-escaping.txt
  lib/lp/translations/stories/standalone/xx-translations-xpi-import.txt

lib/lp/translations/stories/translationgroups/10-distro-translation-group.txt
  lib/lp/translations/templates/productseries-translations.pt
  lib/lp/translations/templates/sourcepackage-translations.pt

« Back to merge proposal