Code review comment for lp:~danilo/launchpad/bug-435398

Revision history for this message
Данило Шеган (danilo) wrote :

= Bug #435346 and bug #435398 =

This improves main content div CSS to include "clear:both" to make sure
sidebars are positioned correctly with very small default font sizes or
with epiphany (bug #435346).

It also reworks the entire 'help for translations' linking CSS to be a
lot nicer and semantical (i.e. drops usage of <ul> and <li> tags),
while at the same time making sure it's not causing ugly layout bugs
(again, a missing clear:both after a floated link).

== Proposed fix ==

Introduce "clear:both" CSS where appropriate.

== Tests ==

bin/test -vvt translation-help

== Demo and Q/A ==

For #435346:

Any launchpad page with sidebars, eg. https://launchpad.dev/firefox and then decrease the font size.

For #435398:

 * https://translations.launchpad.dev/evolution/+translations
 * https://translations.launchpad.dev/ubuntu/hoary/+source/evolution/

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/translations/templates/sourcepackage-translations.pt
  lib/lp/translations/templates/object-templates.pt
  lib/lp/translations/templates/potemplate-index.pt
  lib/lp/translations/templates/distroseries-translations.pt
  lib/canonical/launchpad/icing/style.css
  lib/lp/translations/templates/distribution-translations.pt
  lib/canonical/launchpad/icing/style-3-0.css
  lib/lp/translations/templates/productseries-translations.pt
  lib/lp/translations/templates/product-translations.pt

« Back to merge proposal