Code review comment for lp:~danilo/launchpad/bug-455771

Revision history for this message
Данило Шеган (danilo) wrote :

Incremental diff:

=== modified file 'lib/lp/translations/stories/distroseries/xx-distroseries-translations.txt'
--- lib/lp/translations/stories/distroseries/xx-distroseries-translations.txt 2009-10-21 07:42:20 +0000
+++ lib/lp/translations/stories/distroseries/xx-distroseries-translations.txt 2009-10-22 10:53:49 +0000
@@ -172,10 +172,30 @@
 just prevents that the translation import script, which is executed by cron,
 handle translation imports for this distro series.

+== Translation focus ==
+
+If translation focus is not set, there is no recommendation of what
+release series should be translated.
+
     >>> login('<email address hidden>')
     >>> distribution = factory.makeDistribution(name='earthian')
- >>> distroseries = factory.makeDistroRelease(name='1.4', distribution=distribution)
- >>> logout()
- >>> admin_browser.open('http://translations.launchpad.dev/earthian/1.4')
- >>> admin_browser.url
- 'http://translations.launchpad.dev/earthian/1.4'
+ >>> distroseries = factory.makeDistroRelease(
+ ... name='1.4', distribution=distribution)
+ >>> logout()
+ >>> print distribution.translation_focus
+ None
+ >>> admin_browser.open('http://translations.launchpad.dev/earthian/1.4')
+ >>> print find_tag_by_id(admin_browser.contents, 'translation-focus')
+ None
+
+If focus is set, nice explanatory text is displayed.
+
+ >>> login('<email address hidden>')
+ >>> focus_series = factory.makeDistroRelease(
+ ... name='1.6', distribution=distribution)
+ >>> distribution.translation_focus = focus_series
+ >>> logout()
+ >>> admin_browser.open('http://translations.launchpad.dev/earthian/1.4')
+ >>> print extract_text(
+ ... find_tag_by_id(admin_browser.contents, 'translation-focus'))
+ Launchpad currently recommends translating 1.6.

=== modified file 'lib/lp/translations/templates/distroseries-translations.pt'
--- lib/lp/translations/templates/distroseries-translations.pt 2009-10-21 07:42:20 +0000
+++ lib/lp/translations/templates/distroseries-translations.pt 2009-10-22 10:13:40 +0000
@@ -14,6 +14,7 @@
         <div></div><!-- to clear-up all floats -->
       </div>
       <div class="top-portlet"
+ id="translation-focus"
            tal:condition="context/distribution/translation_focus">
         <p tal:condition="not:view/is_translation_focus">
           Launchpad currently recommends translating

« Back to merge proposal