Merge lp:~danilo/launchpad/bug-458036 into lp:launchpad
Proposed by
Данило Шеган
Status: | Merged |
---|---|
Approved by: | Muharem Hrnjadovic |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~danilo/launchpad/bug-458036 |
Merge into: | lp:launchpad |
Diff against target: |
224 lines 8 files modified
lib/lp/translations/browser/configure.zcml (+2/-2) lib/lp/translations/browser/distroseries.py (+0/-3) lib/lp/translations/browser/productseries.py (+0/-5) lib/lp/translations/stories/distroseries/xx-distroseries-templates.txt (+10/-11) lib/lp/translations/stories/productseries/xx-productseries-templates.txt (+7/-14) lib/lp/translations/templates/distroseries-translations.pt (+3/-3) lib/lp/translations/templates/object-templates.pt (+13/-7) lib/lp/translations/templates/productseries-translations.pt (+3/-3) |
To merge this branch: | bzr merge lp:~danilo/launchpad/bug-458036 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Muharem Hrnjadovic (community) | Approve | ||
Review via email: mp+13787@code.launchpad.net |
Commit message
Allow everyone to access full template listings for ProductSeries and DistroSeries pages.
To post a comment you must log in.
= Bug #458036 =
We've limited access to +templates pages for no particular reason to
product/distro admins. There's no reason these pages couldn't be
completely public (actually, there are many reasons they should be).
== Implementation details ==
Change permissions from launchpad.Edit to zope.Public for the views,
and modify the page templates to show links appropriately (since they
can't assume someone has at least launchpad.Edit on that page anymore).
== Tests ==
bin/test -vvt distroseries- templates. txt -t productseries- templates. txt
== Demo and Q/A ==
Dev:
Log in as <email address hidden>:test and go to:
https:/ /translations. launchpad. dev/evolution/ trunk/ /translations. launchpad. dev/ubuntu/ hoary/
https:/
Look for 'full listing of templates' link that should take you to:
https:/ /translations. launchpad. dev/evolution/ trunk/+ templates /translations. launchpad. dev/ubuntu/ hoary/+ templates
https:/
Log in as <email address hidden>:test and go to the same pages as above.
The only difference is what editing links are shown (i.e. just
"Download" on Ubuntu pages, no "Administrate" on Evolution pages).
Edge:
https:/ /translations. edge.launchpad. net/limewire/ trunk/ /translations. edge.launchpad. net/ubuntu/ karmic/
https:/
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: translations/ templates/ object- templates. pt translations/ templates/ distroseries- translations. pt translations/ browser/ configure. zcml translations/ browser/ distroseries. py translations/ stories/ productseries/ xx-productserie s-templates. txt translations/ templates/ productseries- translations. pt translations/ browser/ productseries. py translations/ stories/ distroseries/ xx-distroseries -templates. txt
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/