Code review comment for lp:~danilo/launchpad/bug-458036

Revision history for this message
Данило Шеган (danilo) wrote :

= Bug #458036 =

We've limited access to +templates pages for no particular reason to
product/distro admins. There's no reason these pages couldn't be
completely public (actually, there are many reasons they should be).

== Implementation details ==

Change permissions from launchpad.Edit to zope.Public for the views,
and modify the page templates to show links appropriately (since they
can't assume someone has at least launchpad.Edit on that page anymore).

== Tests ==

bin/test -vvt distroseries-templates.txt -t productseries-templates.txt

== Demo and Q/A ==

Dev:

 Log in as <email address hidden>:test and go to:

   https://translations.launchpad.dev/evolution/trunk/
   https://translations.launchpad.dev/ubuntu/hoary/

 Look for 'full listing of templates' link that should take you to:

   https://translations.launchpad.dev/evolution/trunk/+templates
   https://translations.launchpad.dev/ubuntu/hoary/+templates

 Log in as <email address hidden>:test and go to the same pages as above.
 The only difference is what editing links are shown (i.e. just
 "Download" on Ubuntu pages, no "Administrate" on Evolution pages).

Edge:

   https://translations.edge.launchpad.net/limewire/trunk/
   https://translations.edge.launchpad.net/ubuntu/karmic/

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/translations/templates/object-templates.pt
  lib/lp/translations/templates/distroseries-translations.pt
  lib/lp/translations/browser/configure.zcml
  lib/lp/translations/browser/distroseries.py
  lib/lp/translations/stories/productseries/xx-productseries-templates.txt
  lib/lp/translations/templates/productseries-translations.pt
  lib/lp/translations/browser/productseries.py
  lib/lp/translations/stories/distroseries/xx-distroseries-templates.txt

« Back to merge proposal