Code review comment for lp:~danilo/launchpad/bug-474874

Revision history for this message
Данило Шеган (danilo) wrote :

= Bug 474874 =

Add missing privileges to rosettaadmin DB user run the one-time script fix_translation_credits. Also provide a minimal test to make sure it works with the new permissions.

= Test =

bin/test -vvt fix_translation_credits

= Demo & QA =

Try re-running it on staging as `scripts/rosetta/fix_translation_credits.py -vvv` after security.cfg changes have been applied.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  database/schema/security.cfg
  lib/lp/translations/doc/fix_translation_credits.txt
  scripts/rosetta/fix_translation_credits.py

« Back to merge proposal