Merge lp:~danilo/launchpad/bug-479385 into lp:launchpad
Proposed by
Данило Шеган
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Данило Шеган | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~danilo/launchpad/bug-479385 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
74 lines (+43/-2) 2 files modified
lib/lp/translations/model/potmsgset.py (+6/-2) lib/lp/translations/tests/test_potmsgset.py (+37/-0) |
||||
To merge this branch: | bzr merge lp:~danilo/launchpad/bug-479385 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Francis J. Lacoste (community) | release-critical | Approve | |
Gavin Panella (community) | code | Approve | |
Review via email: mp+14742@code.launchpad.net |
Commit message
Do not check for permissions when setting translator credits as translated.
To post a comment you must log in.
= Bug 479385 =
Fix failure in setTranslationC reditsToTransla ted when pofile.owner has not agreed to licensing terms. Also use pofile. lasttranslator if it's defined, prior to using pofile.owner.
The only code change in model/potmsgset.py is in setTranslationC reditsToTransla ted to pass pofile. lasttranslator if it's defined and to pass force_edition_ rights= True to updateTranslation call.
This is a CP candidate.
= Tests =
bin/test -vvt setTranslationC reditsToTransla ted
= Demo & QA =
Run scripts/ rosetta/ fix_translation _credits. py over entire DB (that's how we detected the problem in the first place).
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: translations/ model/potmsgset .py translations/ tests/test_ potmsgset. py
lib/lp/
lib/lp/