Code review comment for lp:~danilo/launchpad/bug-479385

Revision history for this message
Данило Шеган (danilo) wrote :

= Bug 479385 =

Fix failure in setTranslationCreditsToTranslated when pofile.owner has not agreed to licensing terms. Also use pofile.lasttranslator if it's defined, prior to using pofile.owner.

The only code change in model/potmsgset.py is in setTranslationCreditsToTranslated to pass pofile.lasttranslator if it's defined and to pass force_edition_rights=True to updateTranslation call.

This is a CP candidate.

= Tests =

bin/test -vvt setTranslationCreditsToTranslated

= Demo & QA =

Run scripts/rosetta/fix_translation_credits.py over entire DB (that's how we detected the problem in the first place).

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/translations/model/potmsgset.py
  lib/lp/translations/tests/test_potmsgset.py

« Back to merge proposal