Code review comment for lp:~danilo/launchpad/bug-494106

Revision history for this message
Данило Шеган (danilo) wrote :

= Bug 494106 =

fix_translation_credits script doesn't pick up where it left off: it simply goes faster through already processed entries, but that means that it runs very, very slow if it runs into locks and such, because it seems DBLoopTuner takes those into account as well.

To fix it, we introduce option to go only through those which have not been fixed yet.

Note: this is a CP candidate.

= Demo & QA =

Query has been QAd on staging, script will be as well.

= Tests =

bin/test -vvct Credits_untranslated

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/translations/model/pofile.py
  lib/lp/translations/scripts/fix_translation_credits.py
  lib/lp/translations/tests/test_pofile.py

« Back to merge proposal