Code review comment for lp:~danilo/launchpad/bug-553093

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi Danilo,

You mentioned that the test reproducing the actual failure takes way too long, and is not worthwhile.

The only ways I can see to get around this are:

Somehow provide a different adapter via zcml (replacing canonical.launchpad.webapp.snapshot.snapshot_sql_result with a similar version but with a limit of 2, for the duration of the test), or

Simply test the interface, that the translators field provides IDoNotSnapshot - this is not as good, but still ensures that the fix is documented and won't regress.

Regarding the template changes, nice simplification!

« Back to merge proposal