Thanks you for starting on the template conversion for translations! Hope people will stop worrying soon ... ;-)
This branch is good to land but please consider these comments.
Please talk to Curtis as you already intended to see if there is an alternative to hacking lazr code.
> + except NoCanonicalUrl:
> + # Drop out of the try-except and return None like it would otherwise.
> + pass
If that hack stays in there, please replace this pseudo-code comment with something that really explains why this exception is ignored.
Cheers, Henning
« Back to merge proposal
Thanks you for starting on the template conversion for translations! Hope people will stop worrying soon ... ;-)
This branch is good to land but please consider these comments.
Please talk to Curtis as you already intended to see if there is an alternative to hacking lazr code.
> + except NoCanonicalUrl:
> + # Drop out of the try-except and return None like it would otherwise.
> + pass
If that hack stays in there, please replace this pseudo-code comment with something that really explains why this exception is ignored.
Cheers,
Henning