Code review comment for lp:~dcbw/libdbusmenu/libdbusmenu

Revision history for this message
Dan Williams (dcbw) wrote :

> Looks good, thanks for your contribution and the nice cleanup.
>
> There's just one small fix to do: http://paste.ubuntu.com/15180692/ otherwise
> libappindicator based menus will be misaligned
> (http://i.imgur.com/DXqeWwy.png)

I was testing nm-applet (which does use libappindicator) using https://extensions.gnome.org/extension/615/appindicator-support/, obligatory screenshot without the halign here:

http://people.redhat.com/dcbw/nm-applet-indicator.png

but the changes don't seem to hurt anything and are likely correct. Repushed.

« Back to merge proposal