Code review comment for lp:~deryck/launchpad/enable-tracking-link-perms-512378

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Deryck,

A nice branch. I have only two minor comments.

> + elif (self.user == self.context.owner or
> + self.user.inTeam(self.context.owner)):

I think the first check is not strictly necessary, self.user.inTeam(self.context.owner) should return True, if self.user == self.context.owner. OTOH, the equaliy check is probably faster that the inTeam() call.

And I wondered if we should also show the link for admins. Again, that's not really important, because the LOSAs know for sure how to change the official_malone flag of a project.

review: Approve (code)

« Back to merge proposal