Code review comment for lp:~deryck/launchpad/fix-affects-me-widget-529049

Revision history for this message
Deryck Hodge (deryck) wrote :

This branch is the second attempt to update to the latest revision in
lazr-js. The first was reverted because the lazr-js change broken the
"affects me too" widget. This has been fixed in lazr-js and now this
branch enables the new version.

I also fixed some tests paths in the js unit tests for bugs. I removed
tests that no longer applied because we removed the flame icon from the
feature.

I've run the Bugs Windmill tests which all pass, but I'll put this
through ec2 before landing, even though it's just UI-related changes.

I would like to have this RC'ed for 10.02 because it allows us to use
our fix for the "changing bug statuses is too easy" bug, which has been
hanging around for awhile causing some pain.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/javascript/bugs/tests/subscriber.html
  versions.cfg
  lib/canonical/launchpad/javascript/bugs/tests/test_subscriber.js
  lib/canonical/launchpad/javascript/bugs/tests/test_me_too.html
  lib/canonical/launchpad/javascript/bugs/tests/test_me_too.js

== JSLint notices ==
jslint: No problem found in
'/home/deryck/launchpad/lp-branches/fix-affects-me-widget-529049/lib/canonical/launchpad/javascript/bugs/tests/test_me_too.js'.

jslint: No problem found in
'/home/deryck/launchpad/lp-branches/fix-affects-me-widget-529049/lib/canonical/launchpad/javascript/bugs/tests/test_subscriber.js'.

jslint: 2 files to lint.

« Back to merge proposal