Launchpad itself

Merge lp:~deryck/launchpad/good-god-comment-fonts-yall into lp:launchpad

  1. good-god-comment-fonts-yall
  2. Merge into devel
Proposed by Deryck Hodge
Status: Merged
Approved by: Deryck Hodge
Approved revision: no longer in the source branch.
Merged at revision: 11460
Proposed branch: lp:~deryck/launchpad/good-god-comment-fonts-yall
Merge into: lp:launchpad
Diff against target: 31 lines (+4/-3)
1 file modified
lib/canonical/launchpad/icing/style-3-0.css.in (+4/-3)
To merge this branch: bzr merge lp:~deryck/launchpad/good-god-comment-fonts-yall
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code + ui Approve
Review via email: mp+33822@code.launchpad.net

Commit message

Fix font sizes for bug comments and merge proposal diffs.

Description of the change

This fixes the font issues with bug comments and merge proposal diffs
currently displayed on edge. I changed the CSS declaration for these
fonts that were using 116%. They are now 93%, which is one of the
recommended YUI font numbers in the stylesheet. This corresponds to
12px and matches, at least from my visual scanning, with the sizes
currently showing on lpnet.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Deryck.

Thanks for providing this fix. I looked at why you made some of theses changes and I think there is a deeper problem. This branch is fine to land as it is--I do not want to expand the scope. I like your changes. Once I saw them, I became distracted by other text that looked too close.

YUI is defining 13px/1.231 on body. Our "html, body" rule does not define line height. At your discretion, you can add "line-height: 120%;" to html, body and decide if you think that fixes the spacing off description on the bug page.

review: Approve (code + ui)
Revision history for this message
Deryck Hodge (deryck) wrote :

Hi, Curtis.

Thanks for the review!

I added the line-height declaration initially and was pleased with the look of the text for descriptions. However, I've since noticed that this cannot be landed without a changed to the lazr-js description editing widget. The increased line-height causes the widget to not align correctly across the top border. I've reverted this rule until we can do the work on the widget, and will land the branch as reviewed.

Cheers,
deryck

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/style-3-0.css.in'
2--- lib/canonical/launchpad/icing/style-3-0.css.in 2010-08-21 13:28:33 +0000
3+++ lib/canonical/launchpad/icing/style-3-0.css.in 2010-08-27 03:59:41 +0000
4@@ -185,7 +185,8 @@
5 width: 60em;
6 }
7 pre, code, samp, tt, .console {
8- font-size: 116%;
9+ font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;
10+ font-size: 93%;
11 margin-bottom: 0.8em;
12 }
13 pre.wrap {
14@@ -1092,7 +1093,7 @@
15 margin-top: 1em;
16 }
17 p.search-results {
18- font-size: 116%;
19+ font-size: 93%;
20 }
21 .top-portlet .summary {
22 margin: 0 0 1em 0;
23@@ -1748,7 +1749,7 @@
24 }
25 pre.changelog, table.diff,
26 .bug-comment, .bug-activity, .codereviewcomment {
27- font-size: 116%;
28+ font-size: 93%;
29 font-family: 'UbuntuBeta Mono', 'Ubuntu Mono', monospace;
30 }
31 .cloud-size-smallest {