Code review comment for lp:~deryck/launchpad/good-god-comment-fonts-yall

Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Deryck.

Thanks for providing this fix. I looked at why you made some of theses changes and I think there is a deeper problem. This branch is fine to land as it is--I do not want to expand the scope. I like your changes. Once I saw them, I became distracted by other text that looked too close.

YUI is defining 13px/1.231 on body. Our "html, body" rule does not define line height. At your discretion, you can add "line-height: 120%;" to html, body and decide if you think that fixes the spacing off description on the bug page.

review: Approve (code + ui)

« Back to merge proposal