Code review comment for lp:~deryck/launchpad/max-heat-by-target-511382

Revision history for this message
Stuart Bishop (stub) wrote :

Will Launchpad have other heat in the future? If so, the column needs to be called max_bug_heat to avoid future name conflicts.

Is 0 a sane default? For heat calculations, I imagine this could lead to division by zero errors. If there is no sane default and the heat calculations explicitly checks for '0', we should just use NULL instead.

Otherwise fine. Allocated number is patch-2207-34-0.sql.

Rather than write a new script to update the max heat cache, I think it would be better to add a new task to garbo-daily.py. This provides infrastructure to do the updates in a database friendly manner (with DBLoopTuner), and test infrastructure to speed up writing your tests.

review: Needs Information (db)

« Back to merge proposal