Code review comment for lp:~deryck/launchpad/max-heat-by-target-511382

Revision history for this message
Björn Tillenius (bjornt) wrote :

I have the same questions as Stuart. For now I think it would be better to call it max_bug_heat to avoid confusion. If we add heat to other things, we can rename it, if we want the heat to be shared.

I also think that NULL should be used to define that heat hasn't been calculated yet, unless using 0 makes things easier. Does it? (Using 0 to have a special value is a bit of a hack, when you are restricted to integer values only.)

I have another question as well, though. You have max_heat for Distribution, DistroSeries, and DistributionSourcePackage. Why not DistroSeriesSourcePackage? Is it necessary to go into the *Series level, or could they just delegate to their non-series counterparts?

review: Needs Information (db)

« Back to merge proposal