Code review comment for lp:~deryck/launchpad/milestone-portlet-links-385719

Revision history for this message
Deryck Hodge (deryck) wrote :

= Summary =

Bug #385719 notes that it's not possible to get to a milestone bug
listing from the bugs home page for a project (or distro either). This
branch adds a milestone-targeted bugs portlet to a bugs home page for a
distro or project, as well as for series bug pages.

= Implementation =

This code pretty much copies the work that creates the series-targeted
bugs portlet. I did change the view class slightly to break out the
bits that get a list of series, since the function for getting
milestones also needs this series list.

I added a page test to cover the new functionality.

== Tests ==

./bin/test -vv -t xx-portlets-bug-milestones.txt

== Demo and Q/A ==

To demo, use the dev server and hit:
https://bugs.launchpad.dev/debian/+bugs

There should be a portlet for the milestone links there.

To QA, visit any project bugs home that use milestones and verify there
is a portlet on the bugs home. https://bugs.launchpad.net/malone/
should have a milestone portlet linking the 3.0 and 2.2.8 milestones.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/bugs/templates/bugtask-portlet-milestonebugs.pt
  lib/lp/bugs/browser/bugtarget.py
  lib/lp/bugs/stories/bugs/xx-portlets-bug-milestones.txt
  lib/lp/bugs/browser/configure.zcml
  lib/lp/bugs/templates/buglisting-default.pt
  lib/lp/bugs/templates/bugtarget-bugs.pt

« Back to merge proposal