Launchpad itself

Code review comment for lp:~deryck/launchpad/minify-app-specific-js-592795

  1. minify-app-specific-js-592795
  2. Merge into devel
Revision history for this message
Māris Fogels (mars) wrote :

Hi Deryck,

I assume the log_none() monkey patch is because this script's output to STDOUT is a programmatic input to another script? It would be nice to put a comment before if that is the case.

I assume you ran this through 'xvfb-run make jscheck'?

And thanks for the Makefile fix.

With the added comment, r=mars.

Maris

review: Approve

« Back to merge proposal