Code review comment for lp:~deryck/launchpad/no-lp-bugs-homepage-439245

= Summary =

This branch started as a fix for Bug #439245, hot bugs listed on project
bugs home when the project doesn't use Launchpad, and in the process we
decided to fix Bug #174473, project home page has search form even when
there are no bugs.

== Proposed fix ==

The fix for the first bug is to check for
view/uses_launchpad_bugtracker, and if this is the case, show the bugs
home page as it currently is on lp.net. If not, we don't show anything
on the home page and add a note that the project does not use Launchpad
for bug tracking. There is also a link provided to edit the project
details and change to use Launchpad if desired.

The fix for the second bug is to check view/hot_bugtasks as a condition
for showing the search form. If there are no hot_bugtasks, there are no
bugs filed against the project.

== Pre-implementation notes ==

This branch was done with me and Brian Fromme pairing at the bug heat
sprint, and we consulted Tom, Graham, and Gavin as needed.

== Implementation details ==

There were several broken tests to fix. In some cases, we removed the
failing sections of a test because the workflow was no longer supported.
  In other cases, we updated the test to update data or use
LaunchpadObjectFactory.

== Tests ==

Updated tests to run include:

./bin/test -cvvt xx-advanced-upstream-pending-bugwatch.txt
./bin/test -cvvt xx-portlets-bug-series.txt
./bin/test -cvvt xx-product-bugs-page.txt
./bin/test -cvvt initial-bug-contacts

We added a test to cover new functionality:

./bin/test -cvvt xx-front-page-info.txt

== Demo and Q/A ==

To demo, create a project and confirm that the bugs home page, i.e.
https://bugs.launchpad.dev/test-project/, does not list any of the
normal bugs info.

Then change the details to use malone and confirm that the page has bug
info listed.

Then, file bugs to confirm that a "Hot bugs" list appears.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
   lib/lp/bugs/stories/bugs/xx-front-page-info.txt

lib/lp/bugs/stories/bugtask-searches/xx-advanced-upstream-pending-bugwatch.txt
   lib/lp/bugs/stories/initial-bug-contacts/10-set-upstream-bugcontact.txt
   lib/lp/bugs/templates/bugtarget-bugs.pt
   lib/lp/bugs/stories/bugs/xx-portlets-bug-series.txt
   lib/lp/bugs/stories/bugs/xx-product-bugs-page.txt