Code review comment for lp:~deryck/launchpad/no-lp-bugs-homepage-439245

Revision history for this message
Eleanor Berger (intellectronica) wrote :

Very nice branch, great to see these bugs fixed at last. As we discussed IRL, a few very minor comments:

1. The text in the doctest reads nicer if its written consistently in present tense.
2. You can use tal:replace instead of tal:content when including the project title to save an unnecessary span element. Just think what it will do for your carbon footprint!

Finally, I'm not sure turning the search box off if no bugs are filed (on a project that does use LP) is better, because one could argue that it helps to have the UI be consistent, so that it's easy to learn. I don't feel deeply about it, but I suggest maybe running it by Martin or Michael.

review: Approve

« Back to merge proposal