Launchpad itself

Code review comment for lp:~deryck/launchpad/not-notified-someone-else-subscribed-494257

  1. not-notified-someone-else-subscribed-494257
  2. Merge into devel
Revision history for this message
Abel Deuring (adeuring) wrote :

(12:49:34) adeuring: deryck: overall, you branch looks good. I just wondered if it makes sense to explicitly test that bug.subscribe(..., send_notifications=False) does indeed not send notifications.
(12:50:01) deryck: adeuring, ah, good point.
(12:50:22) adeuring: deryck: OK, so r=me
(12:50:38) deryck: adeuring, thanks! I'll add the test here in a moment.

review: Approve

« Back to merge proposal