Launchpad itself

Code review comment for lp:~deryck/launchpad/person-bug-page-ui-update-434794

person-bug-page-ui-update-434794
Merge into devel

Revision history for this message

Deryck Hodge (deryck) wrote on 2009-09-23:

On Wed, Sep 23, 2009 at 7:50 AM, Jeroen T. Vermeulen <email address hidden> wrote:
> * I guess there's no time to change this now, but the actions menu is basically a related-pages menu. I don't think it belongs in the sidebar in the new design; it probably ought to be a horizontal line of links at the top or bottom, with an info icon for each.

I thought I followed examples in registry templates for this. If this
needs to be in a grid above the results I can file a bug, but it seems
fine to me as a side bar set. I do know people pages have related
pages in the side in other templates.

Here's an updated diff for everything else:

=== modified file 'lib/lp/bugs/browser/bugtask.py'
--- lib/lp/bugs/browser/bugtask.py 2009-09-23 12:13:38 +0000
+++ lib/lp/bugs/browser/bugtask.py 2009-09-23 13:01:20 +0000
@@ -3325,6 +3325,7 @@
                        "importance", "status"]
     schema = IFrontPageBugTaskSearch
     custom_widget('scope', ProjectScopeWidget)
+ page_title = 'Search'

     def initialize(self):
         """Initialize the view for the request."""
@@ -3359,7 +3360,7 @@
         return "Search all bug reports"

@property
- def page_title(self):
+ def label(self):
return self.getSearchPageHeading()

=== modified file 'lib/lp/bugs/templates/buglisting-embedded-advanced-search.pt'
--- lib/lp/bugs/templates/buglisting-embedded-advanced-search.pt 2009-09-23
04:31:16 +0000
+++ lib/lp/bugs/templates/buglisting-embedded-advanced-search.pt 2009-09-23
12:45:16 +0000
@@ -7,8 +7,6 @@
i18n:domain="launchpad">

<body>
- <h1 metal:fill-slot="heading" tal:content="view/page_title" />
-
   <div metal:fill-slot="side">
     <tal:menu replace="structure context/@@+global-actions" />
     <div tal:condition="view/shouldShowAssignedToTeamPortlet|nothing"

=== modified file 'lib/lp/registry/browser/person.py'
--- lib/lp/registry/browser/person.py 2009-09-23 04:38:00 +0000
+++ lib/lp/registry/browser/person.py 2009-09-23 13:04:10 +0000
@@ -1820,6 +1820,7 @@
"""Bugs reported on packages for a bug subscriber."""

columns_to_show = ["id", "summary", "importance", "status"]
+ page_title = 'Package bugs'

     @property
     def current_package(self):
@@ -2013,6 +2014,10 @@
     def getSimpleSearchURL(self):
         return self.getBugSubscriberPackageSearchURL()

+ @property
+ def label(self):
+ return self.getSearchPageHeading()
+

class RelevantMilestonesMixin:
"""Mixin to narrow the milestone list to only relevant milestones."""
@@ -2033,6 +2038,7 @@

columns_to_show = ["id", "summary", "bugtargetdisplayname",
"importance", "status"]
+ page_title = 'Related bugs'

     def searchUnbatched(self, searchtext=None, context=None,
                         extra_params=None):
@@ -2082,7 +2088,7 @@
         return canonical_url(self.context, view_name="+bugs")

@property
- def page_title(self):
+ def label(self):
return self.getSearchPageHeading()

@@ -2092,6 +2098,7 @@

columns_to_show = ["id", "summary", "bugtargetdisplayname",
"importance", "status"]
+ page_title = 'Assigned bugs'

     def searchUnbatched(self, searchtext=None, context=None,
                         extra_params=None):
@@ -2138,7 +2145,7 @@
         return canonical_url(self.context, view_name="+assignedbugs")

@property
- def page_title(self):
+ def label(self):
return self.getSearchPageHeading()

@@ -2148,6 +2155,7 @@

columns_to_show = ["id", "summary", "bugtargetdisplayname",
"importance", "status"]
+ page_title = 'Commented bugs'

     def searchUnbatched(self, searchtext=None, context=None,
                         extra_params=None):
@@ -2182,7 +2190,7 @@
         return canonical_url(self.context, view_name="+commentedbugs")

@property
- def page_title(self):
+ def label(self):
return self.getSearchPageHeading()

@@ -2192,6 +2200,7 @@

columns_to_show = ["id", "summary", "bugtargetdisplayname",
"importance", "status"]
+ page_title = 'Reported bugs'

     def searchUnbatched(self, searchtext=None, context=None,
                         extra_params=None):
@@ -2237,7 +2246,7 @@
         return False

@property
- def page_title(self):
+ def label(self):
return self.getSearchPageHeading()

@@ -2247,6 +2256,7 @@

columns_to_show = ["id", "summary", "bugtargetdisplayname",
"importance", "status"]
+ page_title = 'Subscribed bugs'

     def searchUnbatched(self, searchtext=None, context=None,
                         extra_params=None):
@@ -2281,7 +2291,7 @@
         return canonical_url(self.context, view_name="+subscribedbugs")

@property
- def page_title(self):
+ def label(self):
return self.getSearchPageHeading()

=== modified file 'lib/lp/registry/stories/foaf/xx-person-bugs.txt'
--- lib/lp/registry/stories/foaf/xx-person-bugs.txt 2009-09-23 04:36:10 +0000
+++ lib/lp/registry/stories/foaf/xx-person-bugs.txt 2009-09-23 13:09:15 +0000
@@ -6,7 +6,7 @@
     >>> anon_browser.open('http://launchpad.dev/~name12')
     >>> anon_browser.getLink('Bugs').click()
     >>> print anon_browser.title
- Bugs related to Sample Person
+ Related bugs
     >>> print anon_browser.url
     http://bugs.launchpad.dev/~name12

@@ -47,7 +47,7 @@

>>> anon_browser.open('http://bugs.launchpad.dev/~name12')
>>> print anon_browser.title
- Bugs related to Sample Person
+ Related bugs

== More specific listings ==
@@ -60,7 +60,7 @@

     >>> anon_browser.getLink('List assigned bugs').click()
     >>> print anon_browser.title
- Bugs assigned to Sample Person : Sample Person
+ Assigned bugs : Sample Person
     >>> print anon_browser.url
     http://bugs.launchpad.dev/~name12/+assignedbugs

@@ -77,7 +77,7 @@

     >>> anon_browser.getLink('List commented bugs').click()
     >>> print anon_browser.title
- Bugs commented on by Sample Person : Sample Person
+ Commented bugs : Sample Person
     >>> print anon_browser.url
     http://bugs.launchpad.dev/~name12/+commentedbugs

@@ -98,7 +98,7 @@

     >>> anon_browser.getLink('List reported bugs').click()
     >>> print anon_browser.title
- Bugs reported by Sample Person : Sample Person
+ Reported bugs : Sample Person
     >>> print anon_browser.url
     http://bugs.launchpad.dev/~name12/+reportedbugs

@@ -127,7 +127,7 @@

     >>> anon_browser.getLink('List subscribed bugs').click()
     >>> print anon_browser.title
- Bugs Sample Person is subscribed to : Sample Person
+ Subscribed bugs : Sample Person
     >>> print anon_browser.url
     http://bugs.launchpad.dev/~name12/+subscribedbugs

On Wed, Sep 23, 2009 at 7:50 AM, Jeroen T. Vermeulen <jtv@canonical.com> wrote:
>  * I guess there's no time to change this now, but the actions menu is basically a related-pages menu.  I don't think it belongs in the sidebar in the new design; it probably ought to be a horizontal line of links at the top or bottom, with an info icon for each.

I thought I followed examples in registry templates for this.  If this
needs to be in a grid above the results I can file a bug, but it seems
fine to me as a side bar set.  I do know people pages have related
pages in the side in other templates.

Here's an updated diff for everything else:

=== modified file 'lib/lp/bugs/browser/bugtask.py'
--- lib/lp/bugs/browser/bugtask.py	2009-09-23 12:13:38 +0000
+++ lib/lp/bugs/browser/bugtask.py	2009-09-23 13:01:20 +0000
@@ -3325,6 +3325,7 @@
                        "importance", "status"]
     schema = IFrontPageBugTaskSearch
     custom_widget('scope', ProjectScopeWidget)
+    page_title = 'Search'

def initialize(self):
         """Initialize the view for the request."""
@@ -3359,7 +3360,7 @@
         return "Search all bug reports"

@property
-    def page_title(self):
+    def label(self):
         return self.getSearchPageHeading()

=== modified file 'lib/lp/bugs/templates/buglisting-embedded-advanced-search.pt'
--- lib/lp/bugs/templates/buglisting-embedded-advanced-search.pt	2009-09-23
04:31:16 +0000
+++ lib/lp/bugs/templates/buglisting-embedded-advanced-search.pt	2009-09-23
12:45:16 +0000
@@ -7,8 +7,6 @@
   i18n:domain="launchpad">

<body>
-  <h1 metal:fill-slot="heading" tal:content="view/page_title" />
-
   <div metal:fill-slot="side">
     <tal:menu replace="structure context/@@+global-actions" />
     <div tal:condition="view/shouldShowAssignedToTeamPortlet|nothing"

=== modified file 'lib/lp/registry/browser/person.py'
--- lib/lp/registry/browser/person.py	2009-09-23 04:38:00 +0000
+++ lib/lp/registry/browser/person.py	2009-09-23 13:04:10 +0000
@@ -1820,6 +1820,7 @@
     """Bugs reported on packages for a bug subscriber."""

columns_to_show = ["id", "summary", "importance", "status"]
+    page_title = 'Package bugs'

@property
     def current_package(self):
@@ -2013,6 +2014,10 @@
     def getSimpleSearchURL(self):
         return self.getBugSubscriberPackageSearchURL()

+    @property
+    def label(self):
+        return self.getSearchPageHeading()
+

class RelevantMilestonesMixin:
     """Mixin to narrow the milestone list to only relevant milestones."""
@@ -2033,6 +2038,7 @@

columns_to_show = ["id", "summary", "bugtargetdisplayname",
                        "importance", "status"]
+    page_title = 'Related bugs'

def searchUnbatched(self, searchtext=None, context=None,
                         extra_params=None):
@@ -2082,7 +2088,7 @@
         return canonical_url(self.context, view_name="+bugs")

@property
-    def page_title(self):
+    def label(self):
         return self.getSearchPageHeading()

@@ -2092,6 +2098,7 @@

columns_to_show = ["id", "summary", "bugtargetdisplayname",
                        "importance", "status"]
+    page_title = 'Assigned bugs'

def searchUnbatched(self, searchtext=None, context=None,
                         extra_params=None):
@@ -2138,7 +2145,7 @@
         return canonical_url(self.context, view_name="+assignedbugs")

@property
-    def page_title(self):
+    def label(self):
         return self.getSearchPageHeading()

@@ -2148,6 +2155,7 @@

columns_to_show = ["id", "summary", "bugtargetdisplayname",
                        "importance", "status"]
+    page_title = 'Commented bugs'

def searchUnbatched(self, searchtext=None, context=None,
                         extra_params=None):
@@ -2182,7 +2190,7 @@
         return canonical_url(self.context, view_name="+commentedbugs")

@property
-    def page_title(self):
+    def label(self):
         return self.getSearchPageHeading()

@@ -2192,6 +2200,7 @@

columns_to_show = ["id", "summary", "bugtargetdisplayname",
                        "importance", "status"]
+    page_title = 'Reported bugs'

def searchUnbatched(self, searchtext=None, context=None,
                         extra_params=None):
@@ -2237,7 +2246,7 @@
         return False

@property
-    def page_title(self):
+    def label(self):
         return self.getSearchPageHeading()

@@ -2247,6 +2256,7 @@

columns_to_show = ["id", "summary", "bugtargetdisplayname",
                        "importance", "status"]
+    page_title = 'Subscribed bugs'

def searchUnbatched(self, searchtext=None, context=None,
                         extra_params=None):
@@ -2281,7 +2291,7 @@
         return canonical_url(self.context, view_name="+subscribedbugs")

@property
-    def page_title(self):
+    def label(self):
         return self.getSearchPageHeading()

=== modified file 'lib/lp/registry/stories/foaf/xx-person-bugs.txt'
--- lib/lp/registry/stories/foaf/xx-person-bugs.txt	2009-09-23 04:36:10 +0000
+++ lib/lp/registry/stories/foaf/xx-person-bugs.txt	2009-09-23 13:09:15 +0000
@@ -6,7 +6,7 @@
     >>> anon_browser.open('http://launchpad.dev/~name12')
     >>> anon_browser.getLink('Bugs').click()
     >>> print anon_browser.title
-    Bugs related to Sample Person
+    Related bugs
     >>> print anon_browser.url
     http://bugs.launchpad.dev/~name12

@@ -47,7 +47,7 @@

>>> anon_browser.open('http://bugs.launchpad.dev/~name12')
     >>> print anon_browser.title
-    Bugs related to Sample Person
+    Related bugs

== More specific listings ==
@@ -60,7 +60,7 @@

>>> anon_browser.getLink('List assigned bugs').click()
     >>> print anon_browser.title
-    Bugs assigned to Sample Person : Sample Person
+    Assigned bugs : Sample Person
     >>> print anon_browser.url
     http://bugs.launchpad.dev/~name12/+assignedbugs

@@ -77,7 +77,7 @@

>>> anon_browser.getLink('List commented bugs').click()
     >>> print anon_browser.title
-    Bugs commented on by Sample Person : Sample Person
+    Commented bugs : Sample Person
     >>> print anon_browser.url
     http://bugs.launchpad.dev/~name12/+commentedbugs

@@ -98,7 +98,7 @@

>>> anon_browser.getLink('List reported bugs').click()
     >>> print anon_browser.title
-    Bugs reported by Sample Person : Sample Person
+    Reported bugs : Sample Person
     >>> print anon_browser.url
     http://bugs.launchpad.dev/~name12/+reportedbugs

@@ -127,7 +127,7 @@

>>> anon_browser.getLink('List subscribed bugs').click()
     >>> print anon_browser.title
-    Bugs Sample Person is subscribed to : Sample Person
+    Subscribed bugs : Sample Person
     >>> print anon_browser.url
     http://bugs.launchpad.dev/~name12/+subscribedbugs

« Back to merge proposal