Launchpad itself

Merge lp:~deryck/launchpad/populate-trac-bug-filing-form-667342 into lp:launchpad

  1. populate-trac-bug-filing-form-667342
  2. Merge into devel
Proposed by Deryck Hodge
Status: Merged
Approved by: Paul Hummer
Approved revision: no longer in the source branch.
Merged at revision: 11847
Proposed branch: lp:~deryck/launchpad/populate-trac-bug-filing-form-667342
Merge into: lp:launchpad
Diff against target: 48 lines (+7/-5)
3 files modified
lib/lp/bugs/browser/tests/bugtask-adding-views.txt (+1/-1)
lib/lp/bugs/doc/bugtracker.txt (+3/-3)
lib/lp/bugs/model/bugtracker.py (+3/-1)
To merge this branch: bzr merge lp:~deryck/launchpad/populate-trac-bug-filing-form-667342
Reviewer Review Type Date Requested Status
Paul Hummer (community) Approve
Review via email: mp+39479@code.launchpad.net

Commit message

Bug filing form link will now fill in summary and description for Trac external bug trackers.

Description of the change

This is a simple fix to fill in the summary and description for Trac bug trackers when a user clicks the bug filing form link on the "affects another project" page. The doc test was corrected to allow these params and then the filing patterns updated. I confirmed on a trac instance that adding these params to the URL will indeed fill in the form.

To post a comment you must log in.
Revision history for this message
Paul Hummer (rockstar) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/bugs/browser/tests/bugtask-adding-views.txt'
--- lib/lp/bugs/browser/tests/bugtask-adding-views.txt 2010-10-18 22:24:59 +0000
+++ lib/lp/bugs/browser/tests/bugtask-adding-views.txt 2010-11-01 15:01:22 +0000
@@ -646,5 +646,5 @@
646 >>> product.bugtracker = trac_bugtracker646 >>> product.bugtracker = trac_bugtracker
647647
648 >>> print_links(add_task_view.upstream_bugtracker_links)648 >>> print_links(add_task_view.upstream_bugtracker_links)
649 bug_filing_url: http://trac.example.com/newticket649 bug_filing_url: http://trac.example.com/newticket?summary=Reflow%20...
650 bug_search_url: http://trac.example.com/search?ticket=on&q=Reflow%20...650 bug_search_url: http://trac.example.com/search?ticket=on&q=Reflow%20...
651651
=== modified file 'lib/lp/bugs/doc/bugtracker.txt'
--- lib/lp/bugs/doc/bugtracker.txt 2010-10-18 22:24:59 +0000
+++ lib/lp/bugs/doc/bugtracker.txt 2010-11-01 15:01:22 +0000
@@ -448,15 +448,15 @@
448 bug_filing_url: http://.../issues/entry?summary=Foo&comment=Bar448 bug_filing_url: http://.../issues/entry?summary=Foo&comment=Bar
449 bug_search_url: http://.../issues/list?q=Foo449 bug_search_url: http://.../issues/list?q=Foo
450450
451Trac's bug filing form doesn't accept data in the query string, so we don't451Trac's bug filing form also accepts data in the query string, so we include
452include it.452it.
453453
454 >>> example_trac = factory.makeBugTracker(454 >>> example_trac = factory.makeBugTracker(
455 ... 'http://trac.example.com', BugTrackerType.TRAC)455 ... 'http://trac.example.com', BugTrackerType.TRAC)
456 >>> links = example_trac.getBugFilingAndSearchLinks(456 >>> links = example_trac.getBugFilingAndSearchLinks(
457 ... remote_product='testproduct', summary="Foo", description="Bar")457 ... remote_product='testproduct', summary="Foo", description="Bar")
458 >>> print_links(links)458 >>> print_links(links)
459 bug_filing_url: http://trac.example.com/newticket459 bug_filing_url: http://trac.example.com/newticket?summary=Foo&description=Bar
460 bug_search_url: http://trac.example.com/search?ticket=on&q=Foo460 bug_search_url: http://trac.example.com/search?ticket=on&q=Foo
461461
462 >>> example_roundup = factory.makeBugTracker(462 >>> example_roundup = factory.makeBugTracker(
463463
=== modified file 'lib/lp/bugs/model/bugtracker.py'
--- lib/lp/bugs/model/bugtracker.py 2010-10-06 17:09:42 +0000
+++ lib/lp/bugs/model/bugtracker.py 2010-11-01 15:01:22 +0000
@@ -233,7 +233,9 @@
233 BugTrackerType.SOURCEFORGE: (233 BugTrackerType.SOURCEFORGE: (
234 "%(base_url)s/%(tracker)s/?func=add&"234 "%(base_url)s/%(tracker)s/?func=add&"
235 "group_id=%(group_id)s&atid=%(at_id)s"),235 "group_id=%(group_id)s&atid=%(at_id)s"),
236 BugTrackerType.TRAC: "%(base_url)s/newticket",236 BugTrackerType.TRAC: (
237 "%(base_url)s/newticket?summary=%(summary)s&"
238 "description=%(description)s"),
237 }239 }
238240
239 _search_url_patterns = {241 _search_url_patterns = {