I'm not comfortable reviewing this branch. There's no description of the change in the merge proposal description and I don't know whether you've had a pre-implementation discussion about the branch.
You need to include the following items when you submit a Launchpad branch for review:
* A description of the change, including a brief list of changes by file
* The output of `make lint`, run in the root of your branch.
* Details of the person with whom you had a pre implementation discussion, including (if necessary) details of why you chose the solution you did.
I'm going to reject this branch; please resubmit it with the above items included. If you want to have a pre-implementation discussion this afternoon I'll be happy to make myself available.
Hi Didier,
I'm not comfortable reviewing this branch. There's no description of the change in the merge proposal description and I don't know whether you've had a pre-implementation discussion about the branch.
You need to include the following items when you submit a Launchpad branch for review:
* A description of the change, including a brief list of changes by file
* The output of `make lint`, run in the root of your branch.
* Details of the person with whom you had a pre implementation discussion, including (if necessary) details of why you chose the solution you did.
I'm going to reject this branch; please resubmit it with the above items included. If you want to have a pre-implementation discussion this afternoon I'll be happy to make myself available.