Code review comment for lp:~didrocks/ubiquity/copy_wallpaper_cache

Revision history for this message
Colin Watson (cjwatson) wrote :

Just some minor comments; this mostly looks OK.

Typo: "ureadheaded" -> "ureadahead".

Please be consistent with the existing copy_network_config method in how you get the casper user's home directory. (If you wanted to move this to a common method in the process, that would be OK.)

You don't need those two unsightly backslash-continuations; line continuations are automatic within brackets of any kind.

There's no need to say 'return' at the end.

review: Needs Fixing

« Back to merge proposal