Code review comment for lp:~dobey/ubuntuone-client/fix-570721-stable

Revision history for this message
dobey (dobey) wrote :

> There should be tests for the change in ubuntuone/syncdaemon/dbus_interface.py
> and ubuntuone/syncdaemon/tools.py.

This change was already approved/landed as-is in trunk, and this is just a backport of that revision to the stable-1-2 branch. I don't think we should be writing tests for stable-1-2 and then trying to forward port them to trunk if necessary. If tests are a must-have for tools.py (which is largely lacking tests outside the scope of this change anyway), these tests should be done in a branch for trunk and then backported to stable-1-2 if necessary. Although I don't think tests are as valuable for most of tools.py as they are simply calling dbus methods which are already tested, inside a Deferred.

« Back to merge proposal