Code review comment for lp:~doxxx/bzr/mergetools

 review needs-fixing

Gordon Tyler wrote:
[...]
> Point, I should just inline _find_executable. I kept it separate since I
> copied it from a public domain source, but I suppose I can modify it how I
> like.

“I copied it from a public domain source” worries me. You link to that source,
<http://snippets.dzone.com/posts/show/6313>, and I don't see anything there that
actually makes that snippet public domain. It explicitly credits a particular
person (as does your comment), and the page itself says “Copyright © 2007 DZone,
Inc.” Nothing on that page says that there is no copyright on that snippet. I
am not a lawyer, but I don't believe “code is shared publically without
explicitly spelled out conditions” can be assumed to imply “code is public
domain.”

So I don't think we can claim “Copyright (C) 2010 Canonical Ltd” for that code,
as your bzrlib/mergetools.py does. AFAICS you don't own the copyright, so you
can't assign it to Canonical Ltd, so we cannot make that claim.

As Vincent wrote, can we use or adapt the logic we already have in
ExecutableFeature._probe instead?

-Andrew.