Code review comment for lp:~doxxx/bzr/mergetools

On 11/25/2010 5:28 PM, Andrew Bennetts wrote:
> So I don't think we can claim “Copyright (C) 2010 Canonical Ltd” for that code,
> as your bzrlib/mergetools.py does. AFAICS you don't own the copyright, so you
> can't assign it to Canonical Ltd, so we cannot make that claim.

Ok.

> As Vincent wrote, can we use or adapt the logic we already have in
> ExecutableFeature._probe instead?

It needs to use Windows PATH_EXT to test for '.exe', '.com', etc. but
otherwise it looks good. I'll extract a function from that into
bzrlib.osutils.