Code review comment for lp:~doxxx/bzr/quiet-serve

Revision history for this message
Gordon Tyler (doxxx) wrote :

> A couple of ways to prevent that
> - use a server startup hook to trigger shutdown.
> - use a thread

Well, silly me, I didn't see the utility functions in TestCmdServeChrooting which do all that. I'll adapt the new testcase to use that.

On a related note, why do the other tests in TestBzrServe launch a subprocess and not do the same thing as TestCmdServeChrooting?

« Back to merge proposal