We never use leading '_' for test classes, even if that may sound reasonable here.
I.e. I understand the intent, but let's not surprise future readers by starting
a new coding rule without good reason.
2) While it's understandable in this patch context that e.args is really stdout, stderr, it will quickly become obscure. A comment will address that.
3) If the exception is raised, None will be returned instead of the (stdout, stderr) tuple. Again, today, the only that cares will pass, but if someone try to reuse the run_bzr_serve_then_func method, he will have a hard time. Please return (None, None) at least.
Really tweaks:
+ class _TestBzrServeBa se(TestCaseWith Transport) :
We never use leading '_' for test classes, even if that may sound reasonable here.
I.e. I understand the intent, but let's not surprise future readers by starting
a new coding rule without good reason.
+ try: bzr(['serve' ] + list(serve_args))
+ self.run_
+ except KeyboardInterrupt as e:
+ return e.args
1) I doubt python2.4 will accept 'as'.
2) While it's understandable in this patch context that e.args is really stdout, stderr, it will quickly become obscure. A comment will address that.
3) If the exception is raised, None will be returned instead of the (stdout, stderr) tuple. Again, today, the only that cares will pass, but if someone try to reuse the run_bzr_ serve_then_ func method, he will have a hard time. Please return (None, None) at least.