Code review comment for lp:~dpm/quickshot/enable-translations

Revision history for this message
David Planella (dpm) wrote :

Note that for Quickshot for be properly translatable constructions of this kind should be avoided:

                self.usersetup.label.set_label(''.join((
                 "<b>Save all your work</b> and click the \"Login\" button to ",
                 "logout and login to this new user to start taking ",
                 "screenshots or, if you want to begin at a later time, ",
                 "click \"Close\".",
                )))

That's just one of the several examples in bin/quickshot. For translators to be able to do their work, these strings should be not truncated (and then they should be surrounded by _() to make them translatable).

« Back to merge proposal