Code review comment for lp:~dpm/ubuntu-docs/html-multiple-locale-output

Revision history for this message
David Planella (dpm) wrote :

I included the ## Icons part of the fix-urls.sh script in the ubuntu-help rule, in:

-e 's|/usr/share/icons/.*/\(.*\.svg\)|img/\1|'\

As per the ## ghelp part of the script, I had done a quick search for ghelp: links in the HTML output at the time I wrote the rule and I couldn't find any, so I thought it wouldn't be needed and discarded it.

Double-checking it now makes me think I was perhaps a bit too quick, as the output seems to contain ghelp links for the following:

orca
synaptic
cheese
baobab
brasero
gucharmap

I guess I should re-add the fix-urls.sh script to cater for those. Does it look like the final list? It strikes me that e.g. the software-center, language-selector and empathy links from the original are gone.

« Back to merge proposal