Ubuntu
ubuntuone-client package

Merge lp:~dpm/ubuntu/lucid/ubuntuone-client/desktop-entry-i18n into lp:ubuntu/lucid/ubuntuone-client

  1. Lucid (10.04)
  2. desktop-entry-i18n
  3. Merge into lucid
Proposed by David Planella
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~dpm/ubuntu/lucid/ubuntuone-client/desktop-entry-i18n
Merge into: lp:ubuntu/lucid/ubuntuone-client
Diff against target: 22 lines (+4/-3)
1 file modified
data/ubuntuone-preferences.desktop.in (+4/-3)
To merge this branch: bzr merge lp:~dpm/ubuntu/lucid/ubuntuone-client/desktop-entry-i18n
Reviewer Review Type Date Requested Status
dobey Disapprove
James Westby (community) Abstain
Review via email: mp+21034@code.launchpad.net

Description of the change

Make the desktop entry translatable.

I haven't marked the other "Name" field, since I'm not too sure what "[U1 Shortcut Group]" is for.

To post a comment you must log in.
lp:~dpm/ubuntu/lucid/ubuntuone-client/desktop-entry-i18n updated
24. By David Planella

Marked the indicator shortcut for translation as well

Revision history for this message
David Planella (dpm) wrote :

After having talked to ted, it seems that translations for the [U1 Shortcut Group] in the app indicator will "just happen" as well, thus marking the other Name key for translation as well.

Revision history for this message
James Westby (james-w) :
review: Abstain
Revision history for this message
dobey (dobey) wrote :

This needs to be done as a branch from the upstream ubuntuone-client tree (lp:ubuntuone-client), and not the packaging branch, unless you're wanting to ship a patch in the tree, in which case it should be a patch.

Also, "Name" is intentionally left untranslated, because it's a proper noun brand name, which should not be translated. Comment should be translated (though Ubuntu One should always be Ubuntu One in all translations), so I'm not sure why it wasn't marked for translation. And X-Ubuntu-Gettext-Domain is I believe automatically added by the packaging. I removed it previously, because of lint complaints from dpkg-buildpackage.

review: Disapprove
Revision history for this message
David Planella (dpm) wrote :

Thanks for the review Rodney, I've now only marked the Comment key for translation against the ubuntuone-client branch and submitted a new merge proposal there (https://code.launchpad.net/~dpm/ubuntuone-client/bug-538217/+merge/21278)

Revision history for this message
dobey (dobey) wrote :

Can someone please change this proposal's status to "Rejected" so that it is out of sight? Thanks.

Unmerged revisions

24. By David Planella

Marked the indicator shortcut for translation as well

23. By David Planella

Make desktop entry translatable

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/ubuntuone-preferences.desktop.in'
2--- data/ubuntuone-preferences.desktop.in 2010-02-17 23:51:29 +0000
3+++ data/ubuntuone-preferences.desktop.in 2010-03-10 16:59:21 +0000
4@@ -1,6 +1,6 @@
5 [Desktop Entry]
6-Name=Ubuntu One
7-Comment=Configure and manage your Ubuntu One account
8+_Name=Ubuntu One
9+_Comment=Configure and manage your Ubuntu One account
10 Exec=ubuntuone-preferences
11 Icon=ubuntuone
12 Terminal=false
13@@ -8,7 +8,8 @@
14 StartupNotify=true
15 Categories=GNOME;GTK;Settings;
16 X-Ayatana-Desktop-Shortcuts=U1
17+X-Ubuntu-Gettext-Domain=ubuntuone-client
18
19 [U1 Shortcut Group]
20-Name=Ubuntu One…
21+_Name=Ubuntu One…
22 Exec=ubuntuone-preferences

Subscribers

People subscribed via source and target branches

to all changes: