Code review comment for lp:~dpm/ubuntu/lucid/ubuntuone-client/desktop-entry-i18n

Revision history for this message
dobey (dobey) wrote :

This needs to be done as a branch from the upstream ubuntuone-client tree (lp:ubuntuone-client), and not the packaging branch, unless you're wanting to ship a patch in the tree, in which case it should be a patch.

Also, "Name" is intentionally left untranslated, because it's a proper noun brand name, which should not be translated. Comment should be translated (though Ubuntu One should always be Ubuntu One in all translations), so I'm not sure why it wasn't marked for translation. And X-Ubuntu-Gettext-Domain is I believe automatically added by the packaging. I removed it previously, because of lint complaints from dpkg-buildpackage.

review: Disapprove

« Back to merge proposal