Code review comment for lp:~eday/nova/compute-abstraction

Revision history for this message
Eric Day (eday) wrote :

I agree on all the points regarding security groups and fixing other things you've filed bugs for. I was trying to just shuffle code around so we only need to edit things in one place, and not actually change the logic.

As far as putting the code in compute manager, I started by creating nova.compute.api, but this felt weird too. It actually made sense to me in the end to put them right next to each other, just knowing they will be on opposite ends of the worker. Perhaps we could just split the class and have both in the manager.py file. I'm open.

« Back to merge proposal