Merge lp:~eday/nova/endpoint-cleanup into lp:~gundlach/nova/controllers-in-api

Proposed by Michael Gundlach
Status: Merged
Merged at revision: 313
Proposed branch: lp:~eday/nova/endpoint-cleanup
Merge into: lp:~gundlach/nova/controllers-in-api
Diff against target: 0 lines
To merge this branch: bzr merge lp:~eday/nova/endpoint-cleanup
Reviewer Review Type Date Requested Status
Michael Gundlach Approve
Review via email: mp+36399@code.launchpad.net

Description of the change

fix endpoint problems

To post a comment you must log in.
Revision history for this message
Michael Gundlach (gundlach) wrote :

looks fine so far

review: Approve
Revision history for this message
Vish Ishaya (vishvananda) wrote :

=== modified file 'nova/api/ec2/metadatarequesthandler.py'
--- nova/api/ec2/metadatarequesthandler.py 2010-09-22 23:11:04 +0000
+++ nova/api/ec2/metadatarequesthandler.py 2010-09-23 02:12:45 +0000
@@ -18,6 +18,7 @@

 """Metadata request handler."""

+import logging
 import webob.dec
 import webob.exc

@@ -63,9 +64,9 @@
         cc = cloud.CloudController()
         meta_data = cc.get_metadata(req.remote_addr)
         if meta_data is None:
- _log.error('Failed to get metadata for ip: %s' % req.remote_addr)
+ logging.error('Failed to get metadata for ip: %s' % req.remote_addr)
             raise webob.exc.HTTPNotFound()
- data = self.lookup(path, meta_data)
+ data = self.lookup(req.path_info, meta_data)
         if data is None:
             raise webob.exc.HTTPNotFound()
         return self.print_data(data)

a couple of typos fixed and it works

Revision history for this message
Devin Carlen (devcamcar) wrote :

In CloudPipe class, in __init__, cloud_controller is passed in but is not referenced. Looks like it can just go away.

208 class CloudPipe(object):
209 def __init__(self, cloud_controller):
210 - self.controller = cloud_controller
211 + self.controller = cloud.CloudController()
212 self.manager = manager.AuthManager()

lp:~eday/nova/endpoint-cleanup updated
308. By Eric Day

Fixed cloudpipe lib init.

309. By Eric Day

Merged gundlach's branch.

310. By Eric Day

Fixed rpc consumer to use unique return connection to prevent overlap. This could be reworked to share a connection, but it should be a wait operation and not a fast poll like it was before. We could also keep a cache of opened connections to be used between requests.

311. By Eric Day

Applied vish's fixes.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: