Code review comment for lp:~eday/nova/endpoint-cleanup

Revision history for this message
Vish Ishaya (vishvananda) wrote :

=== modified file 'nova/api/ec2/metadatarequesthandler.py'
--- nova/api/ec2/metadatarequesthandler.py 2010-09-22 23:11:04 +0000
+++ nova/api/ec2/metadatarequesthandler.py 2010-09-23 02:12:45 +0000
@@ -18,6 +18,7 @@

 """Metadata request handler."""

+import logging
 import webob.dec
 import webob.exc

@@ -63,9 +64,9 @@
         cc = cloud.CloudController()
         meta_data = cc.get_metadata(req.remote_addr)
         if meta_data is None:
- _log.error('Failed to get metadata for ip: %s' % req.remote_addr)
+ logging.error('Failed to get metadata for ip: %s' % req.remote_addr)
             raise webob.exc.HTTPNotFound()
- data = self.lookup(path, meta_data)
+ data = self.lookup(req.path_info, meta_data)
         if data is None:
             raise webob.exc.HTTPNotFound()
         return self.print_data(data)

a couple of typos fixed and it works

« Back to merge proposal