Code review comment for lp:~edwin-grubbs/launchpad/all-downloads-link-sprite

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Summary
-------

In a previous branch, I removed the stylesheet for a.info, since it
was interfering with the "info" class for sprites. This broke a couple
of links. This was corrected by setting class="sprite info".

See the "All downloads" link on https://edge.launchpad.net/bzr

BTW, I also merged devel into db-devel, so that I won't have
to worry about conflicts when pqm is finally working.

Demo and Q/A
------------

* Open https://launchpad.dev/firefox

The other page where this occurs is difficult to view, since
you must be subscribed to a Private PPA. You can subscribe
the name16 (foo.bar) user on launchpad.dev with the following
sql statements.

UPDATE Archive SET private = TRUE, buildd_secret = 'foo' WHERE id = 13;

INSERT INTO ArchiveSubscriber (archive, registrant, subscriber, status)
VALUES (13, 1, 16, 1);

INSERT INTO ArchiveAuthToken (archive, person, token)
VALUES (13, 16, 'asdf');

* https://launchpad.dev/~name16/+archivesubscriptions

« Back to merge proposal