Code review comment for lp:~edwin-grubbs/launchpad/bug-230801-renewing-membership

> Demo and Q/A
> ------------
>
> * Log in as <email address hidden>
> * Open http://launchpad.dev/~guadamen/+members
> * Edit Foo Bar's membership.
> * Set the expiration within 7 days in the future.
> (Surprisingly, you can set the team's admin's membership to expire, and
> before this fix the admin would get the same exception when double
> clicking to renew the membership.)
> * Open http://launchpad.dev/~name16/+expiringmembership/guadamen
> * Double click on the Renew button.

In addition, I had to first set the "invite them to renew their own membership" option on the group before I could renew.

> * Instead of an OOPS, you should the person index page with a notice
> that the membership has been renewed to some time next year.

Nice - I couldn't actually reproduce the problem with Chromium (double-click protection? ;-) , but with Firefox I could.

Not worth worrying about at all, but if you click really really quickly (or perhaps it has to do with the number of clicks and overloading the dev server) you can get more than one notification.

Great! Thanks Edwin.

<EdwinGrubbs> noodles775, al-maisan: can one of you review my tiny branch? https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-230801-renewing-membership/+merge/15610
* beuno is now known as beuno-lunch
<noodles775> EdwinGrubbs: sure!
* noodles775 is loving the 4 or 5 liners :)
<noodles775> EdwinGrubbs: is this targeted to db-devel for a reason? (or are you planning on landing it on devel?)
<EdwinGrubbs> noodles775: I'm planning on landing it on devel after pqm opens, and I wanted to prevent merge conflicts later, since devel still didn't have some of the revisions when I started the branch.
* stub has quit ("Leaving.")
<noodles775> k