Code review comment for lp:~edwin-grubbs/launchpad/bug-248518-setPreferredEmail

Revision history for this message
Curtis Hovey (sinzui) wrote :

I am surprised there is not comparable test for account.activate() in doc/account. I think your test is the only documentation we have. My initial though was to move your test, but I think your decision was right. I think your tests tells other launchpad developer how to get a person's account activated.

I like your graceful solution in the factory.

review: Approve (code)

« Back to merge proposal