Code review comment for lp:~edwin-grubbs/launchpad/bug-297833-invite-private-team

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Putting "<p>Private teams cannot be added as a member of another team.</p>" on ever +add-my-teams page seems a bit crass. I also can't reproduce this problem running from trunk :/

The fix for +addmember is good. It's a bit of a shame the fix has to be at this level, but I don't think there's a choice about this (AFAIK no way for a vocabulary to say "no this thing isn't in this vocabulary *and here's why*).

Abstaining overall, sorry.

review: Abstain

« Back to merge proposal