© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Thu, 08 Oct 2009 05:39:10 -0000
Edwin Grubbs <email address hidden> wrote:
> Hi Gavin,
>
> Thanks for the review. An incremental diff is included at the bottom.
The diff looks really good, and thanks for all your explanations :)
review approve
merge approve
> It took me quite a while to understand how evil prototype
> is. Ahhhhhh. I added an if-statement, although I think that there is
> a good chance that editing the prototype of built-in objects would
> actually cause the downfall of society, in which case, no bug would
> be reported.
:)
On one hand I quite like those libraries that monkeypatch
Array.prototype, String.prototype and others to add familiar and/or
useful methods. But it does make iterating through stuff so much more
difficult. Javascript would benefit from a better iterator protocol
(and, iirc, is getting one or has one in newer specs).