Code review comment for lp:~edwin-grubbs/launchpad/bug-399554-timeline-improvements

Wow - that is amazing Edwin! ui=me* with two suggestions/thoughts below.

In addition to the things you've mentioned, it also looks like you've also reduced the angle of the series line? Which means that it's a much better use of whitespace.

I see that you've ensured that the timeline always displays the current development focus tip by default? That's great - I wonder whether it would make sense to have the series name right-aligned along the milestone lines rather than centred? (ie. so it's always visible in the default project-index display such as shown at:
https://chinstrap.canonical.com/~egrubbs/project_index_page_timeline.png
) Was there a reason for it being centred?

This is probably just related to the state of data on my local lp.dev, but after I ran the script to add the series and milestones, I expected all the 3-6 series to be above the 1.0 series - but they're not:

http://people.canonical.com/~michaeln/tmp/timeline_ordering.png

perhaps it's because currently trunk (0.x) is the development focus? Ah yep, that did it - setting myseries-6 as the development focus (although 1.0 is still the next in the graph?).

Finally, regarding the 'grabability' mentioned in the bug - I wonder whether having separate icons for mouseover and mousedown would help? When I first played with it here, I wondered about the hand icon, clicked and nothing happened. If we had an open-hand-cursor during mouseover, and then when I click (more specifically, while the mouse button is down) the cursor changed to a fist - it might give people more visual feedback? (try clicking when viewing a photo in the default eye-of-gnome app).

Thanks for the excellent work - looking forward to seeing it on edge!