Code review comment for lp:~edwin-grubbs/launchpad/bug-401748-ie8-new-project

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Summary
-------

Fixed problem creating new launchpad projects in IE8.

Implementation details
----------------------

IE8 throws an exception when you try to focus a hidden element.

The help pane's Continue button was also in the middle of the page
because IE8 has a problem with visibility:inherit.

The slider effect was not working on the various sections of licenses
since IE8 doesn't respond to setting the table's height to zero.
Wrapped it in a div.

Fixed a fragile test by adding sleep between actions.

Tests
-----

The bugs only affect IE8, so the tests, which are run in firefox,
don't prove anything except that there were no regressions.

./bin/lp-windmill test=lib/canonical/launchpad/windmill/tests/test_registry/test_plusnew_step1.py firefox http://launchpad.dev:8085
./bin/lp-windmill test=lib/canonical/launchpad/windmill/tests/test_registry/test_plusnew_step2.py firefox http://launchpad.dev:8085

Demo and Q/A
------------

 * Open http://launchpad.dev/projects/+new
    * Enter "firefox", "firefox2", "foo", "bar" and click "Continue".
    * Click on "No, this is a new project."
    * You should see a whole form expand, and the links above the license
      sections should hide/show each section.

« Back to merge proposal