Code review comment for lp:~edwin-grubbs/launchpad/bug-412519-team-page

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

I want to clarify a couple of the suggested changes.

On Mon, Aug 24, 2009 at 2:33 PM, Martin Albisetti<email address hidden> wrote:
> Review: Needs Fixing ui
> Hi Edwin,
>
> This looks great, and I'm looking forward to seeing this land.
>
> I have a few comments which I'd like to see if we can address:
>
> - I feel the "Team details" portlet should always be on the top right. The related projects portlet is pushing it down when it exists

I think I will move the Related Projects portlet to the top on the
left side, since there was a bug to make sure this is very prominent.

> - All the "show all *" links should be on the top-right of each portlet (I can spot "view all members" and view all X related packages)

I'm confused, since we discussed Martin Pool's complaint about the
"Show all" links being black and not being in the body with the other
links. Should it be blue in the top right corner or still black?

> - Maybe in the same spirit, you should move the "view map and time zones" to the top right as well
> - If the team is not a sub-team, can we just not expose that information?
> - How about not mentioning the projects' name again in the polls area and just say "No polls created"?  And maybe not offer the show link if there aren't any?
> - The "created on" date and by whom should be on the top-right, like in bugs and every other object (see with Curtis for this)
> - If there aren't any packages, maybe we shouldn't offer the "Maintained packages" link?
> --
> https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-412519-team-page/+merge/10536
> You are the owner of lp:~edwin-grubbs/launchpad/bug-412519-team-page.
>

« Back to merge proposal