Code review comment for lp:~edwin-grubbs/launchpad/bug-412519-team-page
Revision history for this message
| Edwin Grubbs (edwin-grubbs) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
New screenshots are available at https:/
One important comment below.
> Hi Edwin,
>
> This looks great, and I'm looking forward to seeing this land.
>
> I have a few comments which I'd like to see if we can address:
>
> - I feel the "Team details" portlet should always be on the top right. The
> related projects portlet is pushing it down when it exists
Fixed.
> - All the "show all *" links should be on the top-right of each portlet (I can
> spot "view all members" and view all X related packages)
Fixed.
> - Maybe in the same spirit, you should move the "view map and time zones" to
> the top right as well
Fixed.
> - If the team is not a sub-team, can we just not expose that information?
Fixed.
> - How about not mentioning the projects' name again in the polls area and just
> say "No polls created"? And maybe not offer the show link if there aren't
> any?
Fixed.
> - The "created on" date and by whom should be on the top-right, like in bugs
> and every other object (see with Curtis for this)
Curtis will work on this bug regarding the base template.
> - If there aren't any packages, maybe we shouldn't offer the "Maintained
> packages" link?
Fixed.